netdev - Re: [PATCH bpf-next v2 0/4] samples: bpf: refactor BPF map test with libbpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Jul 2020 12:01:11 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     "Daniel T. Lee" <danieltimlee@...il.com>
Cc:     Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Yonghong Song <yhs@...com>, Martin KaFai Lau <kafai@...com>,
        Andrii Nakryiko <andriin@...com>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 0/4] samples: bpf: refactor BPF map test with libbpf

On Tue, Jul 7, 2020 at 11:49 AM Daniel T. Lee <danieltimlee@...il.com> wrote:
>
> There have been many changes in how the current bpf program defines
> map. The development of libbbpf has led to the new method called
> BTF-defined map, which is a new way of defining BPF maps, and thus has
> a lot of differences from the existing MAP definition method.
>
> Although bpf_load was also internally using libbbpf, fragmentation in
> its implementation began to occur, such as using its own structure,
> bpf_load_map_def, to define the map.
>
> Therefore, in this patch set, map test programs, which are closely
> related to changes in the definition method of BPF map, were refactored
> with libbbpf.
>
> ---

For the series:

Acked-by: Andrii Nakryiko <andriin@...com>

> Changes in V2:
>  - instead of changing event from __x64_sys_connect to __sys_connect,
>  fetch and set register values directly
>  - fix wrong error check logic with bpf_program
>  - set numa_node 0 declaratively at map definition instead of setting it
>  from user-space
>  - static initialization of ARRAY_OF_MAPS element with '.values'
>
> Daniel T. Lee (4):
>   samples: bpf: fix bpf programs with kprobe/sys_connect event
>   samples: bpf: refactor BPF map in map test with libbpf
>   samples: bpf: refactor BPF map performance test with libbpf
>   selftests: bpf: remove unused bpf_map_def_legacy struct
>
>  samples/bpf/Makefile                     |   2 +-
>  samples/bpf/map_perf_test_kern.c         | 188 ++++++++++++-----------
>  samples/bpf/map_perf_test_user.c         | 164 +++++++++++++-------
>  samples/bpf/test_map_in_map_kern.c       |  94 ++++++------
>  samples/bpf/test_map_in_map_user.c       |  53 ++++++-
>  samples/bpf/test_probe_write_user_kern.c |   9 +-
>  tools/testing/selftests/bpf/bpf_legacy.h |  14 --
>  7 files changed, 305 insertions(+), 219 deletions(-)
>
> --
> 2.25.1
>