netdev - RE: [net-next 1/5] ice: add the virtchnl handler for AdminQ command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Jul 2020 01:29:40 +0000
From:   "Wang, Haiyue" <haiyue.wang@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "nhorman@...hat.com" <nhorman@...hat.com>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
        "Lu, Nannan" <nannan.lu@...el.com>,
        "Bowers, AndrewX" <andrewx.bowers@...el.com>
Subject: RE: [net-next 1/5] ice: add the virtchnl handler for AdminQ command

> -----Original Message-----
> From: Jakub Kicinski <kuba@...nel.org>
> Sent: Tuesday, July 14, 2020 06:49
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>
> Cc: davem@...emloft.net; Wang, Haiyue <haiyue.wang@...el.com>; netdev@...r.kernel.org;
> nhorman@...hat.com; sassmann@...hat.com; Kirsher, Jeffrey T <jeffrey.t.kirsher@...el.com>; Lu, Nannan
> <nannan.lu@...el.com>; Bowers, AndrewX <andrewx.bowers@...el.com>
> Subject: Re: [net-next 1/5] ice: add the virtchnl handler for AdminQ command
> 
> On Mon, 13 Jul 2020 10:43:16 -0700 Tony Nguyen wrote:
> > From: Haiyue Wang <haiyue.wang@...el.com>
> >
> > The DCF (Device Config Function) is a named trust VF (always with ID 0,
> > single entity per PF port) that can act as a sole controlling entity to
> > exercise advance functionality such as adding switch rules for the rest
> > of VFs.
> 
> But why? This looks like a bifurcated driver to me.
> 

Yes, like bifurcated about flow control. This expands Intel AVF virtual channel
commands, so that VF can talk to hardware indirectly, which is under control of
PF. Then VF can set up the flow control for other VFs. This enrich current PF's
Flow Director filter for PF itself only by ethtool. 

> > To achieve this approach, this VF is permitted to send some basic AdminQ
> > commands to the PF through virtual channel (mailbox), then the PF driver
> > sends these commands to the firmware, and returns the response to the VF
> > again through virtual channel.
> >
> > The AdminQ command from DCF is split into two parts: one is the AdminQ
> > descriptor, the other is the buffer (the descriptor has BUF flag set).
> > These two parts should be sent in order, so that the PF can handle them
> > correctly.
> >
> > Signed-off-by: Haiyue Wang <haiyue.wang@...el.com>
> > Tested-by: Nannan Lu <nannan.lu@...el.com>
> > Tested-by: Andrew Bowers <andrewx.bowers@...el.com>
> > Signed-off-by: Tony Nguyen <anthony.l.nguyen@...el.com>