netdev - Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Jul 2020 12:03:48 +0800
From:   kernel test robot <lkp@...el.com>
To:     David Thompson <dthompson@...lanox.com>, netdev@...r.kernel.org
Cc:     kbuild-all@...ts.01.org, davem@...emloft.net, kuba@...nel.org,
        jiri@...lanox.com, David Thompson <dthompson@...lanox.com>,
        Asmaa Mnebhi <asmaa@...lanox.com>
Subject: Re: [PATCH net-next] Add Mellanox BlueField Gigabit Ethernet driver

Hi David,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/David-Thompson/Add-Mellanox-BlueField-Gigabit-Ethernet-driver/20200730-023011
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 490ed0b908d371cd9ab63fc142213e5d02d810ee
config: i386-allyesconfig (attached as .config)
compiler: gcc-9 (Debian 9.3.0-14) 9.3.0
reproduce (this is a W=1 build):
        # save the attached .config to linux build tree
        make W=1 ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c: In function 'mlxbf_gige_initial_mac':
>> drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c:1093:6: warning: variable 'status' set but not used [-Wunused-but-set-variable]
    1093 |  int status;
         |      ^~~~~~

vim +/status +1093 drivers/net/ethernet/mellanox/mlxbf_gige/mlxbf_gige_main.c

  1088	
  1089	static void mlxbf_gige_initial_mac(struct mlxbf_gige *priv)
  1090	{
  1091		u8 mac[ETH_ALEN];
  1092		u64 local_mac;
> 1093		int status;
  1094	
  1095		status = mlxbf_gige_get_mac_rx_filter(priv, MLXBF_GIGE_LOCAL_MAC_FILTER_IDX,
  1096						      &local_mac);
  1097		mlxbf_gige_u64_to_mac(mac, local_mac);
  1098	
  1099		if (is_valid_ether_addr(mac)) {
  1100			ether_addr_copy(priv->netdev->dev_addr, mac);
  1101		} else {
  1102			/* Provide a random MAC if for some reason the device has
  1103			 * not been configured with a valid MAC address already.
  1104			 */
  1105			eth_hw_addr_random(priv->netdev);
  1106		}
  1107	
  1108		local_mac = mlxbf_gige_mac_to_u64(priv->netdev->dev_addr);
  1109		mlxbf_gige_set_mac_rx_filter(priv, MLXBF_GIGE_LOCAL_MAC_FILTER_IDX,
  1110					     local_mac);
  1111	}
  1112	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (74148 bytes)