netdev - Re: [PATCH bpf] bpf: xdp: fix XDP mode when no mode flags specified

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Aug 2020 14:29:36 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Lorenzo Bianconi <lorenzo@...nel.org>
Cc:     Andrii Nakryiko <andriin@...com>, bpf <bpf@...r.kernel.org>,
        Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii.nakryiko@...il.com>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf] bpf: xdp: fix XDP mode when no mode flags specified

On Thu, Aug 20, 2020 at 1:24 AM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> > 7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device")
> > inadvertently changed which XDP mode is assumed when no mode flags are
> > specified explicitly. Previously, driver mode was preferred, if driver
> > supported it. If not, generic SKB mode was chosen. That commit changed default
> > to SKB mode always. This patch fixes the issue and restores the original
> > logic.
> >
> > Reported-by: Lorenzo Bianconi <lorenzo@...nel.org>
> > Fixes: 7f0a838254bd ("bpf, xdp: Maintain info on attached XDP BPF programs in net_device")
> > Signed-off-by: Andrii Nakryiko <andriin@...com>
>
> Hi Andrii,
>
> Regarding this patch:
>
> Tested-by: Lorenzo Bianconi <lorenzo@...nel.org>

Applied to bpf tree. Thanks