netdev - Re: [PATCH net-next v2 2/3] net: openvswitch: refactor flow free function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 24 Aug 2020 06:09:26 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     xiangxia.m.yue@...il.com
Cc:     pshelar@....org, xiyou.wangcong@...il.com, dev@...nvswitch.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: openvswitch: refactor flow free
 function

From: xiangxia.m.yue@...il.com
Date: Mon, 24 Aug 2020 15:36:01 +0800

> To avoid a bug when deleting flows in the future, add
> BUG_ON in flush flows function.

BUG_ON() is too severe, I think WARN_ON() or similar are sufficient
because the kernel can try to continue operating if this condition is
detected.

And you can force the values to zero in such a situation.

Thank you.