netdev - Re: [PATCH net] ip: fix tos reflection in ack and reset packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 08 Sep 2020 20:20:33 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     weiwan@...gle.com
Cc:     netdev@...r.kernel.org, edumazet@...gle.com
Subject: Re: [PATCH net] ip: fix tos reflection in ack and reset packets

From: Wei Wang <weiwan@...gle.com>
Date: Tue,  8 Sep 2020 14:09:34 -0700

> Currently, in tcp_v4_reqsk_send_ack() and tcp_v4_send_reset(), we
> echo the TOS value of the received packets in the response.
> However, we do not want to echo the lower 2 ECN bits in accordance
> with RFC 3168 6.1.5 robustness principles.
> 
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> 
> Signed-off-by: Wei Wang <weiwan@...gle.com>
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>

Applied and queued up for -stable, thanks.