netdev - Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 30 Nov 2020 17:08:23 -0800
From:   Hemant Kumar <hemantk@...eaurora.org>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Cc:     gregkh@...uxfoundation.org, linux-arm-msm@...r.kernel.org,
        linux-kernel@...r.kernel.org, jhugo@...eaurora.org,
        bbhatt@...eaurora.org, loic.poulain@...aro.org,
        netdev@...r.kernel.org
Subject: Re: [PATCH v13 4/4] bus: mhi: Add userspace client interface driver

Hi Mani,

On 11/27/20 10:11 PM, Manivannan Sadhasivam wrote:
> Hi Hemant,
> 
> On Fri, Nov 27, 2020 at 07:26:06PM -0800, Hemant Kumar wrote:
>> This MHI client driver allows userspace clients to transfer
>> raw data between MHI device and host using standard file operations.
>> Driver instantiates UCI device object which is associated to device
>> file node. UCI device object instantiates UCI channel object when device
>> file node is opened. UCI channel object is used to manage MHI channels
>> by calling MHI core APIs for read and write operations. MHI channels
>> are started as part of device open(). MHI channels remain in start
>> state until last release() is called on UCI device file node. Device
>> file node is created with format
>>
>> /dev/mhi_<mhi_device_name>
>>
>> Currently it supports QMI channel.
>>
> 
> Thanks for the update. This patch looks good to me. But as I'm going to
> apply Loic's "bus: mhi: core: Indexed MHI controller name" patch, you
> need to update the documentation accordingly.

This is what i added in documentation on v13


Device file node is created with format:-

/dev/mhi_<mhi_device_name>

mhi_device_name includes mhi controller name and the name of the MHI
channel being used by MHI client in userspace to send or receive data
using MHI protocol.


Loic's patch is going to update the controller name as indexed 
controller name, which goes fine with or without his change going first.

For example:   With Loic's change name of device node would be 
/dev/mhi_mhi0_QMI

Without Loic's change it would be

/dev/mhi_0000:00:01.2_QMI

Please let me know if i am missing something.

Thanks,
Hemant

> 
>> Signed-off-by: Hemant Kumar <hemantk@...eaurora.org>
> 
> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> 
> Thanks,
> Mani
> 
[..]
-- 
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project