[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Sat, 12 Dec 2020 12:38:48 +0100
From: Jonas Bonn <jonas@...rbonn.se>
To: Harald Welte <laforge@...monks.org>
Cc: netdev@...r.kernel.org, pablo@...filter.org
Subject: Re: [PATCH net-next v2 04/12] gtp: drop unnecessary call to
skb_dst_drop
On 12/12/2020 10:50, Harald Welte wrote:
> On Fri, Dec 11, 2020 at 01:26:04PM +0100, Jonas Bonn wrote:
>> The call to skb_dst_drop() is already done as part of udp_tunnel_xmit().
>
> I must be blind, can you please point out where exactly this happens?
It's in skb_scrub_packet() which is called by iptunnel_xmit().
/Jonas
>
> I don't see any skb_dst_drop in udp_tunnel_xmit_skb, and
> in iptunnel_xmit() there's only a skb_dst_set (which doesn't call skb_dst_drop internally)
>
Powered by blists - more mailing lists