netdev - Re: [PATCH v3] staging: fix coding style in driver/staging/qlge/qlge

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 16 Feb 2021 12:35:10 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Heiner Kallweit <hkallweit1@...il.com>
Cc:     Du Cheng <ducheng2@...il.com>, Manish Chopra <manishc@...vell.com>,
        devel@...verdev.osuosl.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org
Subject: Re: [PATCH v3] staging: fix coding style in
 driver/staging/qlge/qlge_main.c

On Tue, Feb 16, 2021 at 10:20:22AM +0100, Heiner Kallweit wrote:
> On 16.02.2021 09:53, Du Cheng wrote:
> > align * in block comments on each line
> > 
> > changes v3:
> > - add SUBSYSTEM in subject line
> > - add explanation to past version of this patch
> > 
> > changes v2:
> > - move closing of comment to the same line
> > 
> > changes v1:
> > - align * in block comments
> > 
> > Signed-off-by: Du Cheng <ducheng2@...il.com>
> > ---
> >  drivers/staging/qlge/qlge_main.c | 3 +--
> >  1 file changed, 1 insertion(+), 2 deletions(-)
> > 
> > diff --git a/drivers/staging/qlge/qlge_main.c b/drivers/staging/qlge/qlge_main.c
> > index 5516be3af898..2682a0e474bd 100644
> > --- a/drivers/staging/qlge/qlge_main.c
> > +++ b/drivers/staging/qlge/qlge_main.c
> > @@ -3815,8 +3815,7 @@ static int qlge_adapter_down(struct qlge_adapter *qdev)
> >  
> >  	qlge_tx_ring_clean(qdev);
> >  
> > -	/* Call netif_napi_del() from common point.
> > -	*/
> > +	/* Call netif_napi_del() from common point. */
> >  	for (i = 0; i < qdev->rss_ring_count; i++)
> >  		netif_napi_del(&qdev->rx_ring[i].napi);
> >  
> > 
> Typically such trivial patches aren't much appreciated for staging drivers.
> In the case here I have doubts that the comment as such provides any benefit.

Huh?  What?  I think you have mixed up staging and non-staging.  In
staging we apply this sort of patch all the time.

This patch improves the code.  It's the only warning of this type in the
file.  We will apply it.

If you start down the path of worrying about "is this worth doing" then
you end up wasting maintainer time and developer time.  That's like an
ambiguous thing, right?  We try to avoid ambiguity and be mechanical and
predictable.

We won't apply patches which fix checkpatch warnings if the result is
worse looking code.  This might seem like an ambiguous judgement call to
newbies but it is actually 100% predictable to oldbies.  :P

Anyway the v2 v3 stuff is supposed to be below the --- cut off so please
fix that and resend.

regards,
dan carpenter