netdev - Re: [RFC net-next 2/2] net: dsa: add Realtek RTL8366S switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Feb 2021 16:44:09 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     DENG Qingfang <dqfext@...il.com>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        netdev <netdev@...r.kernel.org>,
        Mauri Sandberg <sandberg@...lfence.com>
Subject: Re: [RFC net-next 2/2] net: dsa: add Realtek RTL8366S switch driver

On Wed, Feb 17, 2021 at 1:25 PM Vladimir Oltean <olteanv@...il.com> wrote:

> I'm not going to do a detailed review on a driver that is a 90% copy of
> rtl8366rb. You should probably spend some time to avoid duplicating
> what is common.

The split of common and individual code comes from the OpenWrt
driver, maybe it wasn't optimal. Maybe we can move some of the
driver into the shared rtl8366.c file.

Yours,
Linus Walleij