netdev - Re: [PATCH net-next v6 0/6] net: qualcomm: rmnet: stop using C bit-fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Mar 2021 20:38:24 -0600
From:   subashab@...eaurora.org
To:     Alex Elder <elder@...aro.org>
Cc:     stranche@...eaurora.org, davem@...emloft.net, kuba@...nel.org,
        sharathv@...eaurora.org, bjorn.andersson@...aro.org,
        evgreen@...omium.org, cpratapa@...eaurora.org,
        David.Laight@...lab.com, olteanv@...il.com,
        alexander.duyck@...il.com, elder@...nel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v6 0/6] net: qualcomm: rmnet: stop using C
 bit-fields

On 2021-03-15 15:51, Alex Elder wrote:
> Version 6 is the same as version 5, but has been rebased on updated
> net-next/master.  With any luck, the patches I'm sending out this
> time won't contain garbage.
> 
> Version 5 of this series responds to a suggestion made by Alexander
> Duyck, to determine the offset to the checksummed range of a packet
> using skb_network_header_len() on patch 2.  I have added his
> Reviewed-by tag to all (other) patches, and removed Bjorn's from
> patch 2.
> 
> The change required some updates to the subsequent patches, and I
> reordered some assignments in a minor way in the last patch.
> 
> I don't expect any more discussion on this series (but will respond
> if there is any).  So at this point I would really appreciate it
> if KS and/or Sean would offer a review, or at least acknowledge it.
> I presume you two are able to independently test the code as well,
> so I request that, and hope you are willing to do so.
> 
> Version 4 of this series is here:
>   
> https://lore.kernel.org/netdev/20210315133455.1576188-1-elder@linaro.org
> 
> 					-Alex
> 
> 
> Alex Elder (6):
>   net: qualcomm: rmnet: mark trailer field endianness
>   net: qualcomm: rmnet: simplify some byte order logic
>   net: qualcomm: rmnet: kill RMNET_MAP_GET_*() accessor macros
>   net: qualcomm: rmnet: use masks instead of C bit-fields
>   net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum 
> trailer
>   net: qualcomm: rmnet: don't use C bit-fields in rmnet checksum header
> 
>  .../ethernet/qualcomm/rmnet/rmnet_handlers.c  | 10 +--
>  .../net/ethernet/qualcomm/rmnet/rmnet_map.h   | 12 ----
>  .../qualcomm/rmnet/rmnet_map_command.c        | 11 +++-
>  .../ethernet/qualcomm/rmnet/rmnet_map_data.c  | 56 ++++++----------
>  include/linux/if_rmnet.h                      | 65 +++++++++----------
>  5 files changed, 64 insertions(+), 90 deletions(-)

For the series

Reviewed-by: Subash Abhinov Kasiviswanathan <subashab@...eaurora.org>