netdev - Re: stmmac: zero udp checksum

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Apr 2021 15:27:29 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Julian Labus <julian@...ifunk-rtk.de>
Cc:     netdev@...r.kernel.org, mschiffer@...verse-factory.net
Subject: Re: stmmac: zero udp checksum

On Mon, Apr 05, 2021 at 02:53:15PM +0200, Julian Labus wrote:
> Hi all,
> 
> in our community mesh network we recently discovered that a TP-Link Archer
> C2600 device is unable to receive IPv6 UDP packets with a zero checksum when
> RX checksum offloading is enabled. The device uses ipq806x-gmac-dwmac for
> its ethernet ports.
> 
> According to https://tools.ietf.org/html/rfc2460#section-8.1 this sounds
> like correct behavior as it says a UDP checksum must not be zero for IPv6
> packets. But this definition was relaxed in
> https://tools.ietf.org/html/rfc6935#section-5 to allow zero checksums in
> tunneling protocols like VXLAN where we discovered the problem.
> 
> Can the behavior of the stmmac driver be changed to meet RFC6935 or would it
> be possible to make the (RX) Checksum Offloading Engine configurable via a
> device tree property to disable it in environments were it causes problems?

Hi Julian

I don't know the stmmac driver at all...

Have you played around with ethtool -k/-K? Can use this to turn off
hardware checksums?

I doubt a DT property would be accepted. What you probably want to do
is react on the NETDEV notifiers for when an upper interface is
changed. If a VXLAN interface is added, turn off hardware checksums.

	 Andrew