netdev - Re: [PATCH 1/3] RDMA/irdma: change the returned type of irdma_sc_repost_aeq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 14 Jul 2021 12:14:58 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     shiraz.saleem@...el.com
Cc:     zyjzyj2000@...il.com, yanjun.zhu@...el.com,
        mustafa.ismail@...el.com, dledford@...hat.com, jgg@...pe.ca,
        linux-rdma@...r.kernel.org, yanjun.zhu@...ux.dev,
        Jakub Kicinski <kuba@...nel.org>,
        linux-netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH 1/3] RDMA/irdma: change the returned type of
 irdma_sc_repost_aeq_entries to void

On Tue, Jul 13, 2021 at 11:11:28PM -0400, yanjun.zhu@...ux.dev wrote:
> From: Zhu Yanjun <yanjun.zhu@...ux.dev>
> 
> The function irdma_sc_repost_aeq_entries always returns zero. So
> the returned type is changed to void.
> 
> Signed-off-by: Zhu Yanjun <yanjun.zhu@...ux.dev>
> ---
>  drivers/infiniband/hw/irdma/ctrl.c | 4 +---
>  drivers/infiniband/hw/irdma/type.h | 3 +--
>  2 files changed, 2 insertions(+), 5 deletions(-)

<...>

> -enum irdma_status_code irdma_sc_repost_aeq_entries(struct irdma_sc_dev *dev,
> -						   u32 count);

I clearly remember that Jakub asked for more than once to remo remove
custom ice/irdma error codes. Did it happen? Can we get rid from them
in RDMA too?

Thanks