netdev - Re: [PATCH bpf-next v2 3/9] tools: resolve_btfids: install libbpf headers when building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Oct 2021 16:01:53 -0700
From:   Andrii Nakryiko <andrii.nakryiko@...il.com>
To:     Quentin Monnet <quentin@...valent.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>,
        Andrii Nakryiko <andrii@...nel.org>,
        Networking <netdev@...r.kernel.org>, bpf <bpf@...r.kernel.org>
Subject: Re: [PATCH bpf-next v2 3/9] tools: resolve_btfids: install libbpf
 headers when building

On Fri, Oct 1, 2021 at 4:09 AM Quentin Monnet <quentin@...valent.com> wrote:
>
> API headers from libbpf should not be accessed directly from the
> library's source directory. Instead, they should be exported with "make
> install_headers". Let's make sure that resolve_btfids installs the
> headers properly when building.
>
> When descending from a parent Makefile, the specific output directories
> for building the library and exporting the headers are configurable with
> LIBBPF_OUT and LIBBPF_DESTDIR, respectively. This is in addition to
> OUTPUT, on top of which those variables are constructed by default.
>
> Also adjust the Makefile for the BPF selftests in order to point to the
> (target) libbpf shared with other tools, instead of building a version
> specific to resolve_btfids.
>
> Signed-off-by: Quentin Monnet <quentin@...valent.com>
> ---
>  tools/bpf/resolve_btfids/Makefile    | 17 ++++++++++++-----
>  tools/bpf/resolve_btfids/main.c      |  4 ++--
>  tools/testing/selftests/bpf/Makefile |  7 +++++--
>  3 files changed, 19 insertions(+), 9 deletions(-)
>

Acked-by: Andrii Nakryiko <andrii@...nel.org>