netdev - RE: [net-next PATCH v6] net: macb: Fix several edge cases in validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 13:18:47 +0000
From:   Parshuram Raju Thombare <pthombar@...ence.com>
To:     Sean Anderson <sean.anderson@...o.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Claudiu Beznea <claudiu.beznea@...rochip.com>,
        Antoine Tenart <atenart@...nel.org>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Milind Parab <mparab@...ence.com>,
        Russell King <linux@...linux.org.uk>
Subject: RE: [net-next PATCH v6] net: macb: Fix several edge cases in validate

>There were several cases where validate() would return bogus supported
>modes with unusual combinations of interfaces and capabilities. For
>example, if state->interface was 10GBASER and the macb had HIGH_SPEED
>and PCS but not GIGABIT MODE, then 10/100 modes would be set anyway. In
>another case, SGMII could be enabled even if the mac was not a GEM
>(despite this being checked for later on in mac_config()). These
>inconsistencies make it difficult to refactor this function cleanly.
>
>There is still the open question of what exactly the requirements for
>SGMII and 10GBASER are, and what SGMII actually supports. If someone
>from Cadence (or anyone else with access to the GEM/MACB datasheet)
>could comment on this, it would be greatly appreciated. In particular,
>what is supported by Cadence vs. vendor extension/limitation?
>
>To address this, the current logic is split into three parts. First, we
>determine what we support, then we eliminate unsupported interfaces, and
>finally we set the appropriate link modes. There is still some cruft
>related to NA, but this can be removed in a future patch.
>
>Signed-off-by: Sean Anderson <sean.anderson@...o.com>

Reviewed-by: Parshuram Thombare <pthombar@...ence.com>

>---
>
>Changes in v6:
>- Fix condition for have_1g (thanks Parshuram)
>
>Changes in v5:
>- Refactor, taking into account Russell's suggestions
>
>Changes in v4:
>- Drop cleanup patch
>- Refactor to just address logic issues
>
>Changes in v3:
>- Order bugfix patch first
>
>Changes in v2:
>- New
>
> drivers/net/ethernet/cadence/macb_main.c | 108 +++++++++++++++--------
> 1 file changed, 71 insertions(+), 37 deletions(-)

Regards,
Parshuram Thombare