[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Sat, 1 Jan 2022 18:03:45 +0800
From: kernel test robot <lkp@...el.com>
To: Kumar Kartikeya Dwivedi <memxor@...il.com>, bpf@...r.kernel.org,
netdev@...r.kernel.org, netfilter-devel@...r.kernel.org
Cc: kbuild-all@...ts.01.org, Luis Chamberlain <mcgrof@...nel.org>,
Jessica Yu <jeyu@...nel.org>,
Josh Poimboeuf <jpoimboe@...hat.com>,
Jiri Kosina <jikos@...nel.org>,
Miroslav Benes <mbenes@...e.cz>,
Petr Mladek <pmladek@...e.com>,
Joe Lawrence <joe.lawrence@...hat.com>
Subject: Re: [PATCH bpf-next v5 1/9] kernel: Add kallsyms_on_each_symbol
variant for single module
Hi Kumar,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on bpf-next/master]
url: https://github.com/0day-ci/linux/commits/Kumar-Kartikeya-Dwivedi/Introduce-unstable-CT-lookup-helpers/20211230-103958
base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: ia64-randconfig-s031-20211230 (https://download.01.org/0day-ci/archive/20220101/202201011858.vOPCCeDV-lkp@intel.com/config)
compiler: ia64-linux-gcc (GCC) 11.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-dirty
# https://github.com/0day-ci/linux/commit/25d6b438335605e4e002f7afde50a3eaf17a0b6c
git remote add linux-review https://github.com/0day-ci/linux
git fetch --no-tags linux-review Kumar-Kartikeya-Dwivedi/Introduce-unstable-CT-lookup-helpers/20211230-103958
git checkout 25d6b438335605e4e002f7afde50a3eaf17a0b6c
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=ia64 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
sparse warnings: (new ones prefixed by >>)
kernel/module.c:2762:23: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct mod_kallsyms [noderef] __rcu *kallsyms @@ got void * @@
kernel/module.c:2762:23: sparse: expected struct mod_kallsyms [noderef] __rcu *kallsyms
kernel/module.c:2762:23: sparse: got void *
>> kernel/module.c:4510:18: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected struct mod_kallsyms *kallsyms @@ got struct mod_kallsyms [noderef] __rcu *kallsyms @@
kernel/module.c:4510:18: sparse: expected struct mod_kallsyms *kallsyms
kernel/module.c:4510:18: sparse: got struct mod_kallsyms [noderef] __rcu *kallsyms
kernel/module.c:2764:12: sparse: sparse: dereference of noderef expression
kernel/module.c:2765:12: sparse: sparse: dereference of noderef expression
kernel/module.c:2767:12: sparse: sparse: dereference of noderef expression
kernel/module.c:2768:12: sparse: sparse: dereference of noderef expression
kernel/module.c:2777:18: sparse: sparse: dereference of noderef expression
kernel/module.c:2778:35: sparse: sparse: dereference of noderef expression
kernel/module.c:2779:20: sparse: sparse: dereference of noderef expression
kernel/module.c:2784:32: sparse: sparse: dereference of noderef expression
kernel/module.c:2787:45: sparse: sparse: dereference of noderef expression
vim +4510 kernel/module.c
4499
4500 int module_kallsyms_on_each_symbol(struct module *mod,
4501 int (*fn)(void *, const char *,
4502 struct module *, unsigned long),
4503 void *data)
4504 {
4505 struct mod_kallsyms *kallsyms;
4506 int ret = 0;
4507
4508 mutex_lock(&module_mutex);
4509 /* We hold module_mutex: no need for rcu_dereference_sched */
> 4510 kallsyms = mod->kallsyms;
4511 if (mod->state != MODULE_STATE_UNFORMED)
4512 ret = __module_kallsyms_on_each_symbol(kallsyms, mod, fn, data);
4513 mutex_unlock(&module_mutex);
4514
4515 return ret;
4516 }
4517
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists