netdev - Re: [PATCH net] sch_cake: diffserv8 CS1 should be bulk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 27 Jan 2022 09:00:14 +0000
From:   Kevin 'ldir' Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>
To:     Toke Høiland-Jørgensen <toke@...hat.com>
Cc:     Matt Johnston <matt@...econstruct.com.au>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
        cake@...ts.bufferbloat.net
Subject: Re: [PATCH net] sch_cake: diffserv8 CS1 should be bulk

> On 25 Jan 2022, at 10:58, Toke Høiland-Jørgensen <toke@...hat.com> wrote:
> 
> Matt Johnston <matt@...econstruct.com.au> writes:
> 
>> The CS1 priority (index 0x08) was changed from 0 to 1 when LE (index
>> 0x01) was added. This looks unintentional, it doesn't match the
>> docs and CS1 shouldn't be the same tin as AF1x
> 
> Hmm, Kevin, any comments?
> 
> -Toke
> 

I’ll have to find my thinking head & time machine :-)
This would be a lot easier if we had ‘diffserv9’, LE could have simply
been added as the ‘if you’ve really nothing better to do’ class that it
is.  And it’s why I’ve personally argued for a diffserv5: lowest;low;normal;high;highest
moving on.

I think I screwed up when LE was added to diffserv8 - Matt the CS1 change from 0 to 1 IS intentional
and IIRC I tried to bump everything else up 1 to compensate.. I may have missed some things though.

Cheers,

Kevin D-B

gpg: 012C ACB2 28C6 C53E 9775  9123 B3A2 389B 9DE2 334A

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)