[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 3 Mar 2022 00:10:36 +0000
From: David Laight <David.Laight@...LAB.COM>
To: 'Krzysztof Kozlowski' <krzysztof.kozlowski@...onical.com>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
"linux-nfc@...ts.01.org" <linux-nfc@...ts.01.org>,
"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [RESEND PATCH v2 4/6] nfc: llcp: use test_bit()
From: Krzysztof Kozlowski
> Sent: 02 March 2022 19:25
>
> Use test_bit() instead of open-coding it, just like in other places
> touching the bitmap.
Except it isn't a bitmap, it is just a structure member that contains bits.
So all the other places should be changes to use C shifts and masks (etc).
David
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
> net/nfc/llcp_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/nfc/llcp_core.c b/net/nfc/llcp_core.c
> index 5ad5157aa9c5..b70d5042bf74 100644
> --- a/net/nfc/llcp_core.c
> +++ b/net/nfc/llcp_core.c
> @@ -383,7 +383,7 @@ u8 nfc_llcp_get_sdp_ssap(struct nfc_llcp_local *local,
> pr_debug("WKS %d\n", ssap);
>
> /* This is a WKS, let's check if it's free */
> - if (local->local_wks & BIT(ssap)) {
> + if (test_bit(ssap, &local->local_wks)) {
> mutex_unlock(&local->sdp_lock);
>
> return LLCP_SAP_MAX;
> --
> 2.32.0
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
Powered by blists - more mailing lists