netdev - Re: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to xfrm_dst

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 Apr 2022 11:50:05 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     David Ahern <dsahern@...nel.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net, pabeni@...hat.com,
        oliver.sang@...el.com
Subject: Re: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to
 xfrm_dst_lookup

On Thu, 31 Mar 2022 19:53:34 -0600 David Ahern wrote:
> To: netdev@...r.kernel.org,  kuba@...nel.org,  davem@...emloft.net,  pabeni@...hat.com
> Cc: oliver.sang@...el.com,  David Ahern <dsahern@...nel.org>
> Subject: [PATCH net] xfrm: Pass flowi_oif or l3mdev as oif to xfrm_dst_lookup

This needs Steffen and Herbert on CC. I'd just CC them in but
patch was marked as Awaiting upstream in our PW already, so
repost would be better. Regardless which tree it ends up getting
applied to.

> The commit referenced in the Fixes tag no longer changes the
> flow oif to the l3mdev ifindex. A xfrm use case was expecting
> the flowi_oif to be the VRF if relevant and the change broke
> that test. Update xfrm_bundle_create to pass oif if set and any
> potential flowi_l3mdev if oif is not set.
> 
> Fixes: 40867d74c374 ("net: Add l3mdev index to flow struct and avoid oif reset for port devices")
> Reported-by: kernel test robot <oliver.sang@...el.com>
> Signed-off-by: David Ahern <dsahern@...nel.org>