netdev - RE: [PATCH net 1/4] i40e: Fix adding ADQ filter to TC0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Jun 2022 11:06:14 +0000
From:   "Jagielski, Jedrzej" <jedrzej.jagielski@...el.com>
To:     Jakub Kicinski <kuba@...nel.org>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "Szczurek, GrzegorzX" <grzegorzx.szczurek@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "sassmann@...hat.com" <sassmann@...hat.com>,
        "Sreenivas, Bharathi" <bharathi.sreenivas@...el.com>
Subject: RE: [PATCH net 1/4] i40e: Fix adding ADQ filter to TC0

>On Thu,  9 Jun 2022 09:26:17 -0700 Tony Nguyen wrote:
>> --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
>> +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
>> @@ -8542,6 +8542,11 @@ static int i40e_configure_clsflower(struct i40e_vsi *vsi,
>>  		return -EOPNOTSUPP;
>>  	}
>>  
>> +	if (!tc) {
>> +		dev_err(&pf->pdev->dev, "Unable to add filter because of invalid destination");
>> +		return -EINVAL;
>> +	}
>
>extacks please ?

Do you mean that the trace should be more informative?

TC0 is a default queue so any filtering rule shouldn't be applied into it.

Thanks,
Jedrzej