netdev - Re: [PATCH net 2/2] net/mlx5e: Fix matchall police parameters validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 Jul 2022 22:45:04 -0700
From:   Saeed Mahameed <saeedm@...dia.com>
To:     Vlad Buslov <vladbu@...dia.com>
Cc:     davem@...emloft.net, kuba@...nel.org, jianbol@...dia.com,
        idosch@...dia.com, xiyou.wangcong@...il.com, jhs@...atatu.com,
        jiri@...nulli.us, netdev@...r.kernel.org, maord@...dia.com
Subject: Re: [PATCH net 2/2] net/mlx5e: Fix matchall police parameters
 validation

On 04 Jul 22:44, Vlad Buslov wrote:
>Referenced commit prepared the code for upcoming extension that allows mlx5
>to offload police action attached to flower classifier. However, with
>regard to existing matchall classifier offload validation should be
>reversed as FLOW_ACTION_CONTINUE is the only supported notexceed police
>action type. Fix the problem by allowing FLOW_ACTION_CONTINUE for police
>action and extend scan_tc_matchall_fdb_actions() to only allow such actions
>with matchall classifier.
>
>Fixes: d97b4b105ce7 ("flow_offload: reject offload for all drivers with invalid police parameters")
>Signed-off-by: Vlad Buslov <vladbu@...dia.com>

Acked-by: Saeed Mahameed <saeedm@...dia.com>