netdev - Re: [PATCH] phy: Add helpers for setting/clearing bits in paged registers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 5 Sep 2022 09:18:42 +0800
From:   kernel test robot <lkp@...el.com>
To:     Olliver Schinagl <oliver@...inagl.nl>, netdev@...r.kernel.org,
        Andrew Lunn <andrew@...n.ch>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        inux-kernel@...r.kernel.org,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Olliver Schinagl <oliver@...inagl.nl>
Subject: Re: [PATCH] phy: Add helpers for setting/clearing bits in paged
 registers

Hi Olliver,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v6.0-rc4 next-20220901]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Olliver-Schinagl/phy-Add-helpers-for-setting-clearing-bits-in-paged-registers/20220905-070318
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 7e18e42e4b280c85b76967a9106a13ca61c16179
config: hexagon-randconfig-r045-20220905 (https://download.01.org/0day-ci/archive/20220905/202209050910.t87wLY38-lkp@intel.com/config)
compiler: clang version 16.0.0 (https://github.com/llvm/llvm-project c55b41d5199d2394dd6cdb8f52180d8b81d809d4)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/342260cb7603ad567f4799836ad4ed390ccedf2a
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Olliver-Schinagl/phy-Add-helpers-for-setting-clearing-bits-in-paged-registers/20220905-070318
        git checkout 342260cb7603ad567f4799836ad4ed390ccedf2a
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/phy/microchip/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from drivers/phy/microchip/lan966x_serdes.c:7:
>> include/linux/phy.h:1275:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           return phy_modify_paged(phydev, page, regnum, 0, val);
                  ^
   include/linux/phy.h:1275:9: note: did you mean 'phy_modify_changed'?
   include/linux/phy.h:1142:5: note: 'phy_modify_changed' declared here
   int phy_modify_changed(struct phy_device *phydev, u32 regnum, u16 mask,
       ^
   include/linux/phy.h:1288:9: error: call to undeclared function 'phy_modify_paged'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
           return phy_modify_paged(phydev, page, regnum, val, 0);
                  ^
   include/linux/phy.h:1447:5: error: conflicting types for 'phy_modify_paged'
   int phy_modify_paged(struct phy_device *phydev, int page, u32 regnum,
       ^
   include/linux/phy.h:1275:9: note: previous implicit declaration is here
           return phy_modify_paged(phydev, page, regnum, 0, val);
                  ^
   3 errors generated.


vim +/phy_modify_paged +1275 include/linux/phy.h

  1264	
  1265	/**
  1266	 * phy_set_bits_paged - Convenience function for setting bits in a paged register
  1267	 * @phydev: the phy_device struct
  1268	 * @page: the page for the phy
  1269	 * @regnum: register number to write
  1270	 * @val: bits to set
  1271	 */
  1272	static inline int phy_set_bits_paged(struct phy_device *phydev, int page,
  1273					     u32 regnum, u16 val)
  1274	{
> 1275		return phy_modify_paged(phydev, page, regnum, 0, val);
  1276	}
  1277	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp