netdev - Re: [[PATCH net]] ptp: ocp: remove symlink for second GNSS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 9 Oct 2022 20:45:41 -0700
From:   Jonathan Lemon <jonathan.lemon@...il.com>
To:     Vadim Fedorenko <vfedorenko@...ek.ru>,
        Jonathan Lemon <jonathan.lemon@...il.com>
Cc:     netdev@...r.kernel.org, Vadim Fedorenko <vadfed@...com>
Subject: Re: [[PATCH net]] ptp: ocp: remove symlink for second GNSS

On 10/9/22 6:29 PM, Vadim Fedorenko wrote:
> Destroy code doesn't remove symlink for ttyGNSS2 device introduced
> earlier. Add cleanup code.
> 
> Fixes: 71d7e0850476 ("ptp: ocp: Add second GNSS device")
> Signed-off-by: Vadim Fedorenko <vadfed@...com>

Thanks, Vadim!

Acked-by: Jonathan Lemon <jonathan.lemon@...il.com>

> ---
>   drivers/ptp/ptp_ocp.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/ptp/ptp_ocp.c b/drivers/ptp/ptp_ocp.c
> index d36c3f597f77..a48d9b7d2921 100644
> --- a/drivers/ptp/ptp_ocp.c
> +++ b/drivers/ptp/ptp_ocp.c
> @@ -3657,6 +3657,7 @@ ptp_ocp_detach_sysfs(struct ptp_ocp *bp)
>   	struct device *dev = &bp->dev;
>   
>   	sysfs_remove_link(&dev->kobj, "ttyGNSS");
> +	sysfs_remove_link(&dev->kobj, "ttyGNSS2");
>   	sysfs_remove_link(&dev->kobj, "ttyMAC");
>   	sysfs_remove_link(&dev->kobj, "ptp");
>   	sysfs_remove_link(&dev->kobj, "pps");