netdev - Re: [PATCH ipsec-next,v4 3/3] xfrm: lwtunnel: add lwtunnel support for xfrm interfaces in collect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 11 Oct 2022 11:03:10 +0300
From:   Eyal Birger <eyal.birger@...il.com>
To:     Ido Schimmel <idosch@...sch.org>
Cc:     davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
        pabeni@...hat.com, steffen.klassert@...unet.com,
        herbert@...dor.apana.org.au, dsahern@...nel.org,
        contact@...elbtn.com, pablo@...filter.org,
        nicolas.dichtel@...nd.com, razor@...ckwall.org,
        daniel@...earbox.net, netdev@...r.kernel.org, bpf@...r.kernel.org
Subject: Re: [PATCH ipsec-next,v4 3/3] xfrm: lwtunnel: add lwtunnel support
 for xfrm interfaces in collect_md mode

Hi Ido,

On Tue, Oct 11, 2022 at 9:41 AM Ido Schimmel <idosch@...sch.org> wrote:
>
> On Fri, Aug 26, 2022 at 02:47:00PM +0300, Eyal Birger wrote:
> > diff --git a/net/core/lwtunnel.c b/net/core/lwtunnel.c
> > index 9ccd64e8a666..6fac2f0ef074 100644
> > --- a/net/core/lwtunnel.c
> > +++ b/net/core/lwtunnel.c
> > @@ -50,6 +50,7 @@ static const char *lwtunnel_encap_str(enum lwtunnel_encap_types encap_type)
> >               return "IOAM6";
> >       case LWTUNNEL_ENCAP_IP6:
> >       case LWTUNNEL_ENCAP_IP:
> > +     case LWTUNNEL_ENCAP_XFRM:
> >       case LWTUNNEL_ENCAP_NONE:
> >       case __LWTUNNEL_ENCAP_MAX:
> >               /* should not have got here */
>
> Eyal,
>
> The warning at the bottom can be triggered [1] from user space when the
> kernel is compiled with CONFIG_MODULES=y and CONFIG_XFRM=n:
>
>  # ip route add 198.51.100.0/24 dev dummy1 encap xfrm if_id 1
>  Error: lwt encapsulation type not supported.
>
> Original report is from a private syzkaller instance which I have
> reduced to the command above.
>
> Thanks

Thanks for the report!

Submitted a fix muting the warning for this case.

Eyal.