netdev - Re: [syzbot] general protection fault in pse_prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 19 Oct 2022 20:04:19 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Xin Long <lucien.xin@...il.com>
Cc:     syzbot <syzbot+81c4b4bbba6eea2cfcae@...kaller.appspotmail.com>,
        andrew@...n.ch, bagasdotme@...il.com, davem@...emloft.net,
        edumazet@...gle.com, linux-kernel@...r.kernel.org,
        linux@...pel-privat.de, lkp@...el.com, netdev@...r.kernel.org,
        pabeni@...hat.com, syzkaller-bugs@...glegroups.com
Subject: Re: [syzbot] general protection fault in pse_prepare_data

On Wed, 19 Oct 2022 22:25:47 -0400 Xin Long wrote:
> > Yeah, looking at ethtool internals - info can be NULL :(  
> It seems that eeprom_prepare_data() doesn't check info before
> accessing info->extack either.

Good catch, looks like that one dumps as well!

Perhaps we should require netdevsim support for all new commands 
going forward :S Otherwise this code is hard for syzbot to exercise.