netdev - Re: [PATCH net] ipv6: fix WARNING in ip6_route_net_exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 1 Nov 2022 20:21:02 -0700
From:   Eric Dumazet <edumazet@...gle.com>
To:     Zhengchao Shao <shaozhengchao@...wei.com>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        yoshfuji@...ux-ipv6.org, dsahern@...nel.org, kuba@...nel.org,
        pabeni@...hat.com, dlezcano@...ibm.com, benjamin.thery@...l.net,
        weiyongjun1@...wei.com, yuehaibing@...wei.com
Subject: Re: [PATCH net] ipv6: fix WARNING in ip6_route_net_exit_late()

On Tue, Nov 1, 2022 at 6:59 PM Zhengchao Shao <shaozhengchao@...wei.com> wrote:
>
> During the initialization of ip6_route_net_init_late(), if file
> ipv6_route or rt6_stats fails to be created, the initialization is
> successful by default. Therefore, the ipv6_route or rt6_stats file
> doesn't be found during the remove in ip6_route_net_exit_late(). It
> will cause WRNING.

>
> Fixes: cdb1876192db ("[NETNS][IPV6] route6 - create route6 proc files for the namespace")
> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
> ---
>  net/ipv6/route.c | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
>

SGTM, thanks.

Reviewed-by: Eric Dumazet <edumazet@...gle.com>