netdev - Re: [PATCH net-next 04/12] net/mlxsw: Convert to i2c's .probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 21 Nov 2022 20:33:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     kernel test robot <lkp@...el.com>, davem@...emloft.net,
        oe-kbuild-all@...ts.linux.dev, netdev@...r.kernel.org,
        edumazet@...gle.com, pabeni@...hat.com, uwe@...ine-koenig.org,
        Ido Schimmel <idosch@...dia.com>
Subject: Re: [PATCH net-next 04/12] net/mlxsw: Convert to i2c's .probe_new()

On Tue, 22 Nov 2022 06:20:23 +0800 kernel test robot wrote:
>    drivers/net/ethernet/mellanox/mlxsw/i2c.c: In function 'mlxsw_i2c_probe':
>    drivers/net/ethernet/mellanox/mlxsw/i2c.c:637:42: error: implicit declaration of function 'i2c_client_get_device_id'; did you mean 'i2c_get_device_id'? [-Werror=implicit-function-declaration]
>      637 |         const struct i2c_device_id *id = i2c_client_get_device_id(client);
>          |                                          ^~~~~~~~~~~~~~~~~~~~~~~~
>          |                                          i2c_get_device_id
> >> drivers/net/ethernet/mellanox/mlxsw/i2c.c:637:42: warning: initialization of 'const struct i2c_device_id *' from 'int' makes pointer from integer without a cast [-Wint-conversion]  
>    cc1: some warnings being treated as errors

Ah, we need to pull that branch you mentioned in the cover letter after
all.. will do tomorrow.