netdev - Re: [PATCH net 1/3] bonding: access curr_active_slave with rtnl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 12 Dec 2022 09:57:05 +0800
From:   Hangbin Liu <liuhangbin@...il.com>
To:     Eric Dumazet <edumazet@...gle.com>
Cc:     netdev@...r.kernel.org, Jay Vosburgh <j.vosburgh@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Jonathan Toppins <jtoppins@...hat.com>,
        Paolo Abeni <pabeni@...hat.com>, liali <liali@...hat.com>
Subject: Re: [PATCH net 1/3] bonding: access curr_active_slave with
 rtnl_dereference

On Sat, Dec 10, 2022 at 06:41:01PM +0100, Eric Dumazet wrote:
> Now, you post a patch for bond_miimon_commit() which already has :
> 
> if (slave == rcu_access_pointer(bond->curr_active_slave))
>       goto do_failover;
> 
> So really it is a matter of consistency in _this_ function, which is
> run under RTNL for sure.

Ah, thanks for the explanation.

> It is also a patch for net-next tree, because it fixes no bug.
> 
> I would not add a Fixes: tag to avoid dealing with useless backports.

OK, I will do as your suggest.

Cheers
Hangbin