netdev - Re: [Intel-wired-lan] [PATCH net] iavf: fix temporary deadlock and failure to set MAC address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 14 Dec 2022 11:24:30 +0800
From:   kernel test robot <lkp@...el.com>
To:     Michal Schmidt <mschmidt@...hat.com>,
        intel-wired-lan@...ts.osuosl.org
Cc:     oe-kbuild-all@...ts.linux.dev, Ivan Vecera <ivecera@...hat.com>,
        netdev@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH net] iavf: fix temporary deadlock and
 failure to set MAC address

Hi Michal,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on net/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Michal-Schmidt/iavf-fix-temporary-deadlock-and-failure-to-set-MAC-address/20221214-085342
patch link:    https://lore.kernel.org/r/20221214005237.379862-1-mschmidt%40redhat.com
patch subject: [Intel-wired-lan] [PATCH net] iavf: fix temporary deadlock and failure to set MAC address
config: x86_64-allyesconfig
compiler: gcc-11 (Debian 11.3.0-8) 11.3.0
reproduce (this is a W=1 build):
        # https://github.com/intel-lab-lkp/linux/commit/82f371e76f81f5ef6b27db5e062d3ad29660d823
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Michal-Schmidt/iavf-fix-temporary-deadlock-and-failure-to-set-MAC-address/20221214-085342
        git checkout 82f371e76f81f5ef6b27db5e062d3ad29660d823
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/net/ethernet/intel/iavf/iavf_main.c: In function 'iavf_init_module':
>> drivers/net/ethernet/intel/iavf/iavf_main.c:5211:13: warning: unused variable 'ret' [-Wunused-variable]
    5211 |         int ret;
         |             ^~~


vim +/ret +5211 drivers/net/ethernet/intel/iavf/iavf_main.c

5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5202  
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5203  /**
56184e01c00d6d2 drivers/net/ethernet/intel/iavf/iavf_main.c     Jesse Brandeburg 2018-09-14  5204   * iavf_init_module - Driver Registration Routine
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5205   *
56184e01c00d6d2 drivers/net/ethernet/intel/iavf/iavf_main.c     Jesse Brandeburg 2018-09-14  5206   * iavf_init_module is the first routine called when the driver is
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5207   * loaded. All it does is register with the PCI subsystem.
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5208   **/
129cf89e585676e drivers/net/ethernet/intel/iavf/i40evf_main.c   Jesse Brandeburg 2018-09-14  5209  static int __init iavf_init_module(void)
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5210  {
227d8d2f7f2278b drivers/net/ethernet/intel/iavf/iavf_main.c     Yuan Can         2022-11-14 @5211  	int ret;
227d8d2f7f2278b drivers/net/ethernet/intel/iavf/iavf_main.c     Yuan Can         2022-11-14  5212  
34a2a3b83e2caf1 drivers/net/ethernet/intel/iavf/iavf_main.c     Jeff Kirsher     2020-05-29  5213  	pr_info("iavf: %s\n", iavf_driver_string);
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5214  
129cf89e585676e drivers/net/ethernet/intel/iavf/i40evf_main.c   Jesse Brandeburg 2018-09-14  5215  	pr_info("%s\n", iavf_copyright);
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5216  
82f371e76f81f5e drivers/net/ethernet/intel/iavf/iavf_main.c     Michal Schmidt   2022-12-14  5217  	return pci_register_driver(&iavf_driver);
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5218  }
5eae00c57f5e42b drivers/net/ethernet/intel/i40evf/i40evf_main.c Greg Rose        2013-12-21  5219  

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

View attachment "config" of type "text/plain" (293460 bytes)