netdev - Re: [PATCH ethtool-next v5 2/2] netlink: add netlink handler for get rss (-x)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 10 Jan 2023 17:54:30 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Sudheer Mogilappagari <sudheer.mogilappagari@...el.com>
Cc:     netdev@...r.kernel.org, mkubecek@...e.cz, andrew@...n.ch,
        sridhar.samudrala@...el.com, anthony.l.nguyen@...el.com
Subject: Re: [PATCH ethtool-next v5 2/2] netlink: add netlink handler for
 get rss (-x)

LGTM! Couple of nit picks

On Mon,  9 Jan 2023 20:52:45 -0800 Sudheer Mogilappagari wrote:
> +	if (hfunc) {
> +		for (i = 0; i < get_count(hash_funcs); i++) {
> +			if (hfunc & (1 << i))
> +				print_string(PRINT_JSON, "rss-hash-function",
> +					     NULL, get_string(hash_funcs, i));

break?

> +		}
> +	}

> +	ret = nlsock_process_reply(nlctx->ethnl2_socket, get_channels_cb, args);
> +
> +	if (ret < 0)
> +		return MNL_CB_ERROR;

no empty lines between function call and the error check