netdev - Re: [PATCH 1/4] virtio_net: notify MAC address change on device initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 23 Jan 2023 19:31:14 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Eli Cohen <elic@...dia.com>
Cc:     Laurent Vivier <lvivier@...hat.com>, linux-kernel@...r.kernel.org,
        "Michael S. Tsirkin" <mst@...hat.com>,
        Parav Pandit <parav@...dia.com>,
        virtualization@...ts.linux-foundation.org, netdev@...r.kernel.org,
        Jason Wang <jasowang@...hat.com>,
        Gautam Dawar <gautam.dawar@...inx.com>,
        Cindy Lu <lulu@...hat.com>,
        "David S. Miller" <davem@...emloft.net>,
        Eugenio Pérez <eperezma@...hat.com>
Subject: Re: [PATCH 1/4] virtio_net: notify MAC address change on device
 initialization

On Sun, 22 Jan 2023 15:47:08 +0200 Eli Cohen wrote:
> > @@ -3956,6 +3958,18 @@ static int virtnet_probe(struct virtio_device *vdev)
> >   	pr_debug("virtnet: registered device %s with %d RX and TX vq's\n",
> >   		 dev->name, max_queue_pairs);
> >   
> > +	/* a random MAC address has been assigned, notify the device */
> > +	if (dev->addr_assign_type == NET_ADDR_RANDOM &&  
> Maybe it's better to not count on addr_assign_type and use a local 
> variable to indicate that virtnet_probe assigned random MAC.

+1, FWIW