netdev - Re: [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 02 Feb 2023 10:47:58 +0100
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Dmitry Torokhov" <dmitry.torokhov@...il.com>,
        "Wei Fang" <wei.fang@....com>, "Jakub Kicinski" <kuba@...nel.org>,
        "Andrew Lunn" <andrew@...n.ch>
Cc:     "Shenwei Wang" <shenwei.wang@....com>,
        "Clark Wang" <xiaoning.wang@....com>,
        "NXP Linux Team" <linux-imx@....com>,
        "David S . Miller" <davem@...emloft.net>,
        "Eric Dumazet" <edumazet@...gle.com>,
        "Paolo Abeni" <pabeni@...hat.com>,
        "Marc Kleine-Budde" <mkl@...gutronix.de>,
        Netdev <netdev@...r.kernel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/2] net: fec: restore handling of PHY reset line as optional

On Wed, Feb 1, 2023, at 22:53, Dmitry Torokhov wrote:
> Conversion of the driver to gpiod API done in 468ba54bd616 ("fec:
> convert to gpio descriptor") incorrectly made reset line mandatory and
> resulted in aborting driver probe in cases where reset line was not
> specified (note: this way of specifying PHY reset line is actually
> deprecated).
>
> Switch to using devm_gpiod_get_optional() and skip manipulating reset
> line if it can not be located.
>
> Fixes: 468ba54bd616 ("fec: convert to gpio descriptor")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
> ---
>
> v3: removed handling of 'phy-reset-active-high', it was moved to patch #2
> v2: dropped conversion to generic device properties from the patch

Thanks for fixing it,

Reviewed-by: Arnd Bergmann <arnd@...db.de>