netdev - RE: [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2023 15:52:27 +0000
From:   "Song, Yoong Siang" <yoong.siang.song@...el.com>
To:     "Lobakin, Alexandr" <alexandr.lobakin@...el.com>,
        Jesper Dangaard Brouer <jbrouer@...hat.com>
CC:     Stanislav Fomichev <sdf@...gle.com>,
        Toke Høiland-Jørgensen <toke@...hat.com>,
        "Brouer, Jesper" <brouer@...hat.com>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        "ast@...nel.org" <ast@...nel.org>,
        "daniel@...earbox.net" <daniel@...earbox.net>,
        "andrii@...nel.org" <andrii@...nel.org>,
        "song@...nel.org" <song@...nel.org>, "yhs@...com" <yhs@...com>,
        "john.fastabend@...il.com" <john.fastabend@...il.com>,
        "kpsingh@...nel.org" <kpsingh@...nel.org>,
        "haoluo@...gle.com" <haoluo@...gle.com>,
        "jolsa@...nel.org" <jolsa@...nel.org>,
        David Ahern <dsahern@...il.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Willem de Bruijn <willemb@...gle.com>,
        "Burakov, Anatoly" <anatoly.burakov@...el.com>,
        Magnus Karlsson <magnus.karlsson@...il.com>,
        "Tahhan, Maryam" <mtahhan@...hat.com>,
        "xdp-hints@...-project.net" <xdp-hints@...-project.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "bpf@...r.kernel.org" <bpf@...r.kernel.org>,
        "Brandeburg, Jesse" <jesse.brandeburg@...el.com>,
        "Nguyen, Anthony L" <anthony.l.nguyen@...el.com>
Subject: RE: [xdp-hints] Re: [PATCH bpf-next v8 00/17] xdp: hints via kfuncs

>
>From: Jesper Dangaard Brouer <jbrouer@...hat.com>
>Date: Tue, 24 Jan 2023 13:23:49 +0100
>
>>
>> On 24/01/2023 12.49, Toke Høiland-Jørgensen wrote:
>>> Alexander Lobakin <alexandr.lobakin@...el.com> writes:
>>>
>>>> From: Stanislav Fomichev <sdf@...gle.com>
>>>> Date: Mon, 23 Jan 2023 10:55:52 -0800
>>>>
>>>>> On Mon, Jan 23, 2023 at 10:53 AM Martin KaFai Lau
>>>>> <martin.lau@...ux.dev> wrote:
>>>>>>
>>>>>> On 1/19/23 2:15 PM, Stanislav Fomichev wrote:
>>>>>>> Please see the first patch in the series for the overall design
>>>>>>> and use-cases.
>>>>>>>
>>>>>>> See the following email from Toke for the per-packet metadata
>>>>>>> overhead:
>>>>>>> https://lore.kernel.org/bpf/20221206024554.3826186-1-sdf@google.c
>>>>>>> om/T/#m49d48ea08d525ec88360c7d14c4d34fb0e45e798
>>>>>>>
>>>>>>> Recent changes:
>>>>>>> - Keep new functions in en/xdp.c, do 'extern
>>>>>>> mlx5_xdp_metadata_ops' (Tariq)
>>>>>>>
>>>>>>> - Remove mxbuf pointer and use xsk_buff_to_mxbuf (Tariq)
>>>>>>>
>>>>>>> - Clarify xdp_buff vs 'XDP frame' (Jesper)
>>>>>>>
>>>>>>> - Explicitly mention that AF_XDP RX descriptor lacks metadata
>>>>>>> size
>>>>>>> (Jesper)
>>>>>>>
>>>>>>> - Drop libbpf_flags/xdp_flags from selftests and use ifindex
>>>>>>> instead
>>>>>>>     of ifname (due to recent xsk.h refactoring)
>>>>>>
>>>>>> Applied with the minor changes in the selftests discussed in patch
>>>>>> 11 and 17.
>>>>>> Thanks!
>>>>>
>>>>> Awesome, thanks! I was gonna resend around Wed, but thank you for
>>>>> taking care of that!
>>>> Great stuff, congrats! :)
>>>
>>> Yeah! Thanks for carrying this forward, Stanislav! :)
>>
>> +1000 -- great work everybody! :-)
>>
>> To Alexander (Cc Jesse and Tony), do you think someone from Intel
>> could look at extending drivers:
>>
>>  drivers/net/ethernet/intel/igb/ - chip i210
>>  drivers/net/ethernet/intel/igc/ - chip i225
>>  drivers/net/ethernet/stmicro/stmmac - for CPU integrated LAN ports
>
>Sorry, just noticed :s
>
>I work with ice only, but seems like the responsible teams started some work
>already. At least for i225. They may write some follow-ups soon.
>
Hi Jesper,

FYI, me and my team will enable Rx metadata on stmmac and igc for Rx HWTS.
Will submit the patches for review after done.
>>
>> We have a customer that have been eager to get hardware
>> RX-timestamping for their AF_XDP use-case (PoC code[1] use software
>> timestamping via
>> bpf_ktime_get_ns() today).  Getting driver support will qualify this
>> hardware as part of their HW solution.
>>
>> --Jesper
>> [1]
>> https://github.com/xdp-project/bpf-examples/blob/master/AF_XDP-interac
>> tion/af_xdp_kern.c#L77
>>
>
>Thanks,
>Olek

Thanks & Regards
Siang