netdev - Re: [PATCH net v5 0/2] mlx5: ptp fifo bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 2 Feb 2023 10:53:00 -0800
From:   Saeed Mahameed <saeed@...nel.org>
To:     Vadim Fedorenko <vadfed@...a.com>
Cc:     Jakub Kicinski <kuba@...nel.org>,
        Vadim Fedorenko <vadim.fedorenko@...ux.dev>,
        Rahul Rameshbabu <rrameshbabu@...dia.com>,
        Tariq Toukan <ttoukan.linux@...il.com>,
        Gal Pressman <gal@...dia.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net v5 0/2] mlx5: ptp fifo bugfixes

On 02 Feb 09:13, Vadim Fedorenko wrote:
>Simple FIFO implementation for PTP queue has several bugs which lead to
>use-after-free and skb leaks. This series fixes the issues and adds new
>checks for this FIFO implementation to uncover the same problems in
>future.
>

Thanks Vadim, Applied to net-mlx5.

>v4 -> v5:
>  Change check to WARN_ON_ONCE() in mlx5e_skb_fifo_pop()
>  Change the check of OOO cqe as Jakub provided corner case
>  Move OOO logic into separate function and add counter
>v3 -> v4:
>  Change pr_err to mlx5_core_err_rl per suggest
>  Removed WARN_ONCE on fifo push because has_room() should catch the
>  issue
>v2 -> v3:
>  Rearrange patches order and rephrase commit messages
>  Remove counters as Gal confirmed FW bug, use KERN_ERR message instead
>  Provide proper budget to napi_consume_skb as Jakub suggested
>v1 -> v2:
>  Update Fixes tag to proper commit.
>  Change debug line to avoid double print of function name
>
>Vadim Fedorenko (2):
>  mlx5: fix skb leak while fifo resync and push
>  mlx5: fix possible ptp queue fifo use-after-free
>
> .../net/ethernet/mellanox/mlx5/core/en/ptp.c  | 25 ++++++++++++++++---
> .../net/ethernet/mellanox/mlx5/core/en/txrx.h |  4 ++-
> .../ethernet/mellanox/mlx5/core/en_stats.c    |  1 +
> .../ethernet/mellanox/mlx5/core/en_stats.h    |  1 +
> 4 files changed, 27 insertions(+), 4 deletions(-)
>
>-- 
>2.30.2
>