netdev - Re: [PATCH 17/17] crypto: api - Remove completion function scaffolding

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Feb 2023 02:56:34 +0200
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Herbert Xu <herbert@...dor.apana.org.au>
Cc:     Linux Crypto Mailing List <linux-crypto@...r.kernel.org>,
        Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...nel.org>, dm-devel@...hat.com,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
        Tyler Hicks <code@...icks.com>, ecryptfs@...r.kernel.org,
        Marcel Holtmann <marcel@...tmann.org>,
        Johan Hedberg <johan.hedberg@...il.com>,
        Luiz Augusto von Dentz <luiz.dentz@...il.com>,
        linux-bluetooth@...r.kernel.org,
        Steffen Klassert <steffen.klassert@...unet.com>,
        Jon Maloy <jmaloy@...hat.com>,
        Ying Xue <ying.xue@...driver.com>,
        Boris Pismenny <borisp@...dia.com>,
        John Fastabend <john.fastabend@...il.com>,
        David Howells <dhowells@...hat.com>, keyrings@...r.kernel.org
Subject: Re: [PATCH 17/17] crypto: api - Remove completion function
 scaffolding

On Mon, Feb 06, 2023 at 06:22:46PM +0800, Herbert Xu wrote:
> This patch removes the temporary scaffolding now that the comletion
> function signature has been converted.
> 
> Signed-off-by: Herbert Xu <herbert@...dor.apana.org.au>

For the 1-17:

Acked-by: Jarkko Sakkinen <jarkko@...nel.org>

(nit applies tho to all of them but use your own judgement i guess)

> ---
> 
>  include/linux/crypto.h |    6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/include/linux/crypto.h b/include/linux/crypto.h
> index 80f6350fb588..bb1d9b0e1647 100644
> --- a/include/linux/crypto.h
> +++ b/include/linux/crypto.h
> @@ -176,7 +176,6 @@ struct crypto_async_request;
>  struct crypto_tfm;
>  struct crypto_type;
>  
> -typedef void crypto_completion_data_t;
>  typedef void (*crypto_completion_t)(void *req, int err);
>  
>  /**
> @@ -596,11 +595,6 @@ struct crypto_wait {
>  /*
>   * Async ops completion helper functioons
>   */
> -static inline void *crypto_get_completion_data(void *data)
> -{
> -	return data;
> -}
> -
>  void crypto_req_done(void *req, int err);
>  
>  static inline int crypto_wait_req(int err, struct crypto_wait *wait)

BR, Jarkko