netdev - Re: [PATCH net-next v3] net: wangxun: Add the basic ethtool interfaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 17:23:02 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Mengyuan Lou <mengyuanlou@...-swift.com>
Cc:     netdev@...r.kernel.org, jiawenwu@...stnetic.com
Subject: Re: [PATCH net-next v3] net: wangxun: Add the basic ethtool
 interfaces

On Tue, Feb 14, 2023 at 05:15:27PM +0800, Mengyuan Lou wrote:
> Add the basic ethtool ops get_drvinfo and get_link for ngbe and txgbe.
> Ngbe implements get_link_ksettings, nway_reset and set_link_ksettings
> for free using phylib code.
> The code related to the physical interface is not yet fully implemented
> in txgbe using phylink code. So do not implement get_link_ksettings,
> nway_reset and set_link_ksettings in txgbe.
> 
> Signed-off-by: Mengyuan Lou <mengyuanlou@...-swift.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew