netdev - Re: [PATCH] fixed typos on selftests/bpf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Feb 2023 08:44:02 -0800
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Taichi Nishimura <awkrail01@...il.com>, shuah@...nel.org,
        andrii@...nel.org, mykolal@...com, ast@...nel.org,
        daniel@...earbox.net, martin.lau@...ux.dev, song@...nel.org,
        yhs@...com, john.fastabend@...il.com, kpsingh@...nel.org,
        sdf@...gle.com, haoluo@...gle.com, jolsa@...nel.org,
        davem@...emloft.net, kuba@...nel.org, hawk@...nel.org,
        nathan@...nel.org, ndesaulniers@...gle.com, trix@...hat.com,
        ytcoode@...il.com, deso@...teo.net, joannelkoong@...il.com
Cc:     linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org,
        netdev@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH] fixed typos on selftests/bpf

Hi--

On 2/14/23 07:28, Taichi Nishimura wrote:
> I run spell checker and found typos in selftest/bpf/ files.
> Fixed all of the detected typos.
> 
> This patch is an extra credit for kselftest task
> in the Linux kernel bug fixing spring unpaid 2023.
> 
> Best regards,
> Taichi Nishimura
> 
> Signed-off-by: Taichi Nishimura <awkrail01@...il.com>
> ---
>  tools/testing/selftests/bpf/prog_tests/migrate_reuseport.c    | 2 +-
>  tools/testing/selftests/bpf/prog_tests/trampoline_count.c     | 2 +-
>  tools/testing/selftests/bpf/progs/btf_dump_test_case_syntax.c | 2 +-
>  tools/testing/selftests/bpf/progs/dynptr_fail.c               | 2 +-
>  tools/testing/selftests/bpf/progs/strobemeta.h                | 2 +-
>  tools/testing/selftests/bpf/progs/test_cls_redirect.c         | 4 ++--
>  tools/testing/selftests/bpf/progs/test_subprogs.c             | 2 +-
>  tools/testing/selftests/bpf/progs/test_xdp_vlan.c             | 2 +-
>  tools/testing/selftests/bpf/test_cpp.cpp                      | 2 +-
>  tools/testing/selftests/bpf/veristat.c                        | 4 ++--
>  10 files changed, 12 insertions(+), 12 deletions(-)
> 

Issues here:

> @@ -610,7 +610,7 @@ static INLINING ret_t get_next_hop(buf_t *pkt, encap_headers_t *encap,
>   *
>   *    fill_tuple(&t, foo, sizeof(struct iphdr), 123, 321)
>   *
> - * clang will substitue a costant for sizeof, which allows the verifier
> + * clang will substitute a costant for sizeof, which allows the verifier

                              constant

>   * to track it's value. Based on this, it can figure out the constant

               its value.

>   * return value, and calling code works while still being "generic" to
>   * IPv4 and IPv6.

The other changes look good. Thanks.

After fixing the issues above:
Reviewed-by: Randy Dunlap <rdunlap@...radead.org>


-- 
~Randy