netdev - Re: [PATCH v3 net-next] sfc: fix ia64 builds without CONFIG_RTC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 20 Feb 2023 10:27:01 +0000
From:   "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
To:     Simon Horman <simon.horman@...igine.com>,
        "Lucero Palau, Alejandro" <alejandro.lucero-palau@....com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-net-drivers (AMD-Xilinx)" <linux-net-drivers@....com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "habetsm.xilinx@...il.com" <habetsm.xilinx@...il.com>,
        "ecree.xilinx@...il.com" <ecree.xilinx@...il.com>,
        "linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
        "corbet@....net" <corbet@....net>,
        "jiri@...dia.com" <jiri@...dia.com>
Subject: Re: [PATCH v3 net-next] sfc: fix ia64 builds without CONFIG_RTC_LIB


On 2/19/23 13:24, Simon Horman wrote:
> Hi Alejandro,
>
> On Sat, Feb 18, 2023 at 12:56:20AM +0000, alejandro.lucero-palau@....com wrote:
>> From: Alejandro Lucero <alejandro.lucero-palau@....com>
>>
>> Add an embarrassingly missed semicolon plus and embarrassingly missed
>> parenthesis breaking kernel building in ia64 configs.
> I think this statement is slightly misleading.
>
> The problem may have manifested when building for ia64 config.
> However, I don't believe that it is, strictly speaking, an ia64 issue.
> Rather, I believe the problem is build without CONFIG_RTC_LIB.
>
> Some architectures select CONFIG_RTC_LIB., f.e. x86_64. But some do not.
> ia64 is one such example. arm64 is another - indeed I was able to reproduce
> the bug when building for arm64 using config based on the one at the link
> below.
>
> I think it would be helpful to update the patch description accordingly.
>
> Code change looks good to me: I exercised builds for both ia64 and arm64.
>
Hi Simon,

I agree. In fact, I did not initially specify ia64 in the subject, but I 
got a warning suggesting maybe I should do it.

I guess that suggestion is likely due to adding the Reported and Link 
tags, but as you say, it is not describing the problem properly.

I will change it in v4.

Thanks, and thank you for testing.

>> Reported-by: kernel test robot <lkp@...el.com>
>> Link: https://lore.kernel.org/oe-kbuild-all/202302170047.EjCPizu3-lkp@intel.com/
>> Fixes: 14743ddd2495 ("sfc: add devlink info support for ef100")
>> Signed-off-by: Alejandro Lucero <alejandro.lucero-palau@....com>
>> ---
>>   drivers/net/ethernet/sfc/efx_devlink.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/ethernet/sfc/efx_devlink.c b/drivers/net/ethernet/sfc/efx_devlink.c
>> index d2eb6712ba35..c829362ca99f 100644
>> --- a/drivers/net/ethernet/sfc/efx_devlink.c
>> +++ b/drivers/net/ethernet/sfc/efx_devlink.c
>> @@ -323,7 +323,7 @@ static void efx_devlink_info_running_v2(struct efx_nic *efx,
>>   				    GET_VERSION_V2_OUT_SUCFW_BUILD_DATE);
>>   		rtc_time64_to_tm(tstamp, &build_date);
>>   #else
>> -		memset(&build_date, 0, sizeof(build_date)
>> +		memset(&build_date, 0, sizeof(build_date));
>>   #endif
>>   		build_id = MCDI_DWORD(outbuf, GET_VERSION_V2_OUT_SUCFW_CHIP_ID);
>>   
>> -- 
>> 2.17.1
>>