netdev - RE: [PATCH v2 net] net:usb:lan78xx: fix accessing the LAN7800's internal phy specific registers from the MAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 28 Feb 2023 18:54:23 +0000
From:   <Yuiko.Oshino@...rochip.com>
To:     <andrew@...n.ch>
CC:     <enguerrand.de-ribaucourt@...oirfairelinux.com>,
        <Woojung.Huh@...rochip.com>, <hkallweit1@...il.com>,
        <netdev@...r.kernel.org>, <pabeni@...hat.com>,
        <davem@...emloft.net>, <UNGLinuxDriver@...rochip.com>,
        <linux@...linux.org.uk>, <edumazet@...gle.com>,
        <linux-usb@...r.kernel.org>, <kuba@...nel.org>
Subject: RE: [PATCH v2 net] net:usb:lan78xx: fix accessing the LAN7800's
 internal phy specific registers from the MAC driver

>-----Original Message-----
>From: Andrew Lunn <andrew@...n.ch>
>Sent: Friday, February 17, 2023 9:23 AM
>To: Yuiko Oshino - C18177 <Yuiko.Oshino@...rochip.com>
>Cc: enguerrand.de-ribaucourt@...oirfairelinux.com; Woojung Huh - C21699
><Woojung.Huh@...rochip.com>; hkallweit1@...il.com; netdev@...r.kernel.org;
>pabeni@...hat.com; davem@...emloft.net; UNGLinuxDriver
><UNGLinuxDriver@...rochip.com>; linux@...linux.org.uk; edumazet@...gle.com;
>linux-usb@...r.kernel.org; kuba@...nel.org
>Subject: Re: [PATCH v2 net] net:usb:lan78xx: fix accessing the LAN7800's internal
>phy specific registers from the MAC driver
>
>EXTERNAL EMAIL: Do not click links or open attachments unless you know the
>content is safe
>
>On Fri, Feb 17, 2023 at 06:09:00AM -0700, Yuiko Oshino wrote:
>> Move the LAN7800 internal phy (phy ID  0x0007c132) specific register accesses to
>the phy driver (microchip.c).
>>
>> Fix the error reported by Enguerrand de Ribaucourt in December 2022,
>> "Some operations during the cable switch workaround modify the
>> register LAN88XX_INT_MASK of the PHY. However, this register is
>> specific to the
>> LAN8835 PHY. For instance, if a DP8322I PHY is connected to the
>> LAN7801, that register (0x19), corresponds to the LED and MAC address
>> configuration, resulting in inappropriate behavior."
>>
>> I did not test with the DP8322I PHY, but I tested with an EVB-LAN7800 with the
>internal PHY.
>
>Please keep you commit message lines less than 80 characters.
>
>> Fixes: 14437e3fa284f465dbbc8611fd4331ca8d60e986 ("lan78xx: workaround
>> of forced 100 Full/Half duplex mode error")
>
>Please use the short hash, not the long.
>
>The Fixes: tag is an exception to the 80 characters rule, it can be as long as it needs
>to be.
>
>Otherwise this patch looks good now.
>
>          Andrew

Thank you, Andrew!

I will do v3 shortly.

Yuiko