netdev - Re: [PATCH net] bnxt_en: reset PHC frequency in free-running mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 7 Mar 2023 10:40:47 +0800
From:   kernel test robot <lkp@...el.com>
To:     Vadim Fedorenko <vadfed@...a.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Pavan Chebbi <pavan.chebbi@...adcom.com>,
        Andy Gospodarek <andrew.gospodarek@...adcom.com>,
        Michael Chan <michael.chan@...adcom.com>
Cc:     llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
        Vadim Fedorenko <vadfed@...a.com>,
        Richard Cochran <richardcochran@...il.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: reset PHC frequency in free-running mode

Hi Vadim,

I love your patch! Yet something to improve:

[auto build test ERROR on net/master]

url:    https://github.com/intel-lab-lkp/linux/commits/Vadim-Fedorenko/bnxt_en-reset-PHC-frequency-in-free-running-mode/20230307-005700
patch link:    https://lore.kernel.org/r/20230306165344.350387-1-vadfed%40meta.com
patch subject: [PATCH net] bnxt_en: reset PHC frequency in free-running mode
config: riscv-randconfig-r042-20230306 (https://download.01.org/0day-ci/archive/20230307/202303071016.BkAkCGA9-lkp@intel.com/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project 67409911353323ca5edf2049ef0df54132fa1ca7)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install riscv cross compiling tool for clang build
        # apt-get install binutils-riscv64-linux-gnu
        # https://github.com/intel-lab-lkp/linux/commit/26d7b40eb9dd69f66a477fab7cf51d98c3fe63de
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Vadim-Fedorenko/bnxt_en-reset-PHC-frequency-in-free-running-mode/20230307-005700
        git checkout 26d7b40eb9dd69f66a477fab7cf51d98c3fe63de
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv olddefconfig
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=riscv SHELL=/bin/bash drivers/net/ethernet/broadcom/bnxt/

If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@...el.com>
| Link: https://lore.kernel.org/oe-kbuild-all/202303071016.BkAkCGA9-lkp@intel.com/

All errors (new ones prefixed by >>):

>> drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:948:4: error: call to undeclared function 'bnxt_ptp_adjfreq_rtc'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
                           bnxt_ptp_adjfreq_rtc(bp, 0);
                           ^
   drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:948:4: note: did you mean 'bnxt_ptp_adjfine_rtc'?
   drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c:208:12: note: 'bnxt_ptp_adjfine_rtc' declared here
   static int bnxt_ptp_adjfine_rtc(struct bnxt *bp, long scaled_ppm)
              ^
   1 error generated.


vim +/bnxt_ptp_adjfreq_rtc +948 drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c

   919	
   920	int bnxt_ptp_init(struct bnxt *bp, bool phc_cfg)
   921	{
   922		struct bnxt_ptp_cfg *ptp = bp->ptp_cfg;
   923		int rc;
   924	
   925		if (!ptp)
   926			return 0;
   927	
   928		rc = bnxt_map_ptp_regs(bp);
   929		if (rc)
   930			return rc;
   931	
   932		if (ptp->ptp_clock && bnxt_pps_config_ok(bp))
   933			return 0;
   934	
   935		bnxt_ptp_free(bp);
   936	
   937		atomic_set(&ptp->tx_avail, BNXT_MAX_TX_TS);
   938		spin_lock_init(&ptp->ptp_lock);
   939	
   940		if (BNXT_PTP_RTC(ptp->bp)) {
   941			bnxt_ptp_timecounter_init(bp, false);
   942			rc = bnxt_ptp_init_rtc(bp, phc_cfg);
   943			if (rc)
   944				goto out;
   945		} else {
   946			bnxt_ptp_timecounter_init(bp, true);
   947			if (bp->fw_cap & BNXT_FW_CAP_PTP_RTC)
 > 948				bnxt_ptp_adjfreq_rtc(bp, 0);
   949		}
   950	
   951		ptp->ptp_info = bnxt_ptp_caps;
   952		if ((bp->fw_cap & BNXT_FW_CAP_PTP_PPS)) {
   953			if (bnxt_ptp_pps_init(bp))
   954				netdev_err(bp->dev, "1pps not initialized, continuing without 1pps support\n");
   955		}
   956		ptp->ptp_clock = ptp_clock_register(&ptp->ptp_info, &bp->pdev->dev);
   957		if (IS_ERR(ptp->ptp_clock)) {
   958			int err = PTR_ERR(ptp->ptp_clock);
   959	
   960			ptp->ptp_clock = NULL;
   961			rc = err;
   962			goto out;
   963		}
   964		if (bp->flags & BNXT_FLAG_CHIP_P5) {
   965			spin_lock_bh(&ptp->ptp_lock);
   966			bnxt_refclk_read(bp, NULL, &ptp->current_time);
   967			WRITE_ONCE(ptp->old_time, ptp->current_time);
   968			spin_unlock_bh(&ptp->ptp_lock);
   969			ptp_schedule_worker(ptp->ptp_clock, 0);
   970		}
   971		return 0;
   972	
   973	out:
   974		bnxt_ptp_free(bp);
   975		bnxt_unmap_ptp_regs(bp);
   976		return rc;
   977	}
   978	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests