netdev - RE: [PATCH net v3 1/3] net: phylink: add phylink_expects

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 29 Mar 2023 09:34:05 +0000
From:   "Sit, Michael Wei Hong" <michael.wei.hong.sit@...el.com>
To:     Russell King <linux@...linux.org.uk>,
        Jakub Kicinski <kuba@...nel.org>
CC:     Giuseppe Cavallaro <peppe.cavallaro@...com>,
        Alexandre Torgue <alexandre.torgue@...s.st.com>,
        Jose Abreu <joabreu@...opsys.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        "Paolo Abeni" <pabeni@...hat.com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        "Ong, Boon Leong" <boon.leong.ong@...el.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "Looi, Hong Aun" <hong.aun.looi@...el.com>,
        "Voon, Weifeng" <weifeng.voon@...el.com>,
        "Lai, Peter Jun Ann" <peter.jun.ann.lai@...el.com>
Subject: RE: [PATCH net v3 1/3] net: phylink: add phylink_expects_phy() method



> -----Original Message-----
> From: Russell King <linux@...linux.org.uk>
> Sent: Wednesday, March 29, 2023 5:01 PM
> To: Jakub Kicinski <kuba@...nel.org>
> Cc: Sit, Michael Wei Hong <michael.wei.hong.sit@...el.com>;
> Giuseppe Cavallaro <peppe.cavallaro@...com>; Alexandre Torgue
> <alexandre.torgue@...s.st.com>; Jose Abreu
> <joabreu@...opsys.com>; David S . Miller <davem@...emloft.net>;
> Eric Dumazet <edumazet@...gle.com>; Paolo Abeni
> <pabeni@...hat.com>; Maxime Coquelin
> <mcoquelin.stm32@...il.com>; Ong, Boon Leong
> <boon.leong.ong@...el.com>; netdev@...r.kernel.org; linux-
> stm32@...md-mailman.stormreply.com; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org; Looi,
> Hong Aun <hong.aun.looi@...el.com>; Voon, Weifeng
> <weifeng.voon@...el.com>; Lai, Peter Jun Ann
> <peter.jun.ann.lai@...el.com>
> Subject: Re: [PATCH net v3 1/3] net: phylink: add
> phylink_expects_phy() method
> 
> On Tue, Mar 28, 2023 at 06:57:20PM -0700, Jakub Kicinski wrote:
> > On Fri, 24 Mar 2023 16:16:54 +0800 Michael Sit Wei Hong wrote:
> > > Provide phylink_expects_phy() to allow MAC drivers to check if it
> is
> > > expecting a PHY to attach to. Since fixed-linked setups do not
> need
> > > to attach to a PHY.
> > >
> > > Provides a boolean value as to if the MAC should expect a PHY.
> > > returns true if a PHY is expected.
> > >
> > > Signed-off-by: Michael Sit Wei Hong
> <michael.wei.hong.sit@...el.com>
> >
> > Russell, looks good?
> 
> Not really, given that phylink_attach_phy() will refuse to attach a
> PHY
> when:
> 
>         if (WARN_ON(pl->cfg_link_an_mode == MLO_AN_FIXED ||
>                     (pl->cfg_link_an_mode == MLO_AN_INBAND &&
>                      phy_interface_mode_is_8023z(interface) && !pl-
> >sfp_bus)))
>                 return -EINVAL;
> 
> So, if we introduce a helper named "phylink_expects_phy" that
> returns true when cfg_link_an_mode == MLO_AN_INBAND and the
> interface mode is e.g. 1000base-X, but then someone tries to attach
> a PHY, the kernel spits out a warning, backtrace, and a return value
> of -EINVAL, things are going to look really rather stupid.
> 
Should we check for these 3 conditions as well then?
(pl->cfg_link_an_mode == MLO_AN_INBAND &&
phy_interface_mode_is_8023z(interface) && !pl->sfp_bus)
to determine if phylink expects a phy.

> --
> RMK's Patch system:
> https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!