netdev - Re: [net V2 01/10] net/mlx5e: Don't clone flow post action attributes second time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 22 Apr 2023 03:50:20 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Saeed Mahameed <saeed@...nel.org>
Cc:     davem@...emloft.net, kuba@...nel.org, pabeni@...hat.com,
        edumazet@...gle.com, saeedm@...dia.com, netdev@...r.kernel.org,
        tariqt@...dia.com, vladbu@...dia.com, roid@...dia.com
Subject: Re: [net V2 01/10] net/mlx5e: Don't clone flow post action attributes
 second time

Hello:

This series was applied to netdev/net.git (main)
by Saeed Mahameed <saeedm@...dia.com>:

On Thu, 20 Apr 2023 18:50:48 -0700 you wrote:
> From: Vlad Buslov <vladbu@...dia.com>
> 
> The code already clones post action attributes in
> mlx5e_clone_flow_attr_for_post_act(). Creating another copy in
> mlx5e_tc_post_act_add() is a erroneous leftover from original
> implementation. Instead, assign handle->attribute to post_attr provided by
> the caller. Note that cloning the attribute second time is not just
> wasteful but also causes issues like second copy not being properly updated
> in neigh update code which leads to following use-after-free:
> 
> [...]

Here is the summary with links:
  - [net,V2,01/10] net/mlx5e: Don't clone flow post action attributes second time
    https://git.kernel.org/netdev/net/c/e9fce818fe00
  - [net,V2,02/10] net/mlx5e: Release the label when replacing existing ct entry
    https://git.kernel.org/netdev/net/c/8ac04a28144c
  - [net,V2,03/10] net/mlx5: E-switch, Create per vport table based on devlink encap mode
    https://git.kernel.org/netdev/net/c/fd745f4c0abe
  - [net,V2,04/10] net/mlx5: E-switch, Don't destroy indirect table in split rule
    https://git.kernel.org/netdev/net/c/4c8189302567
  - [net,V2,05/10] net/mlx5: Release tunnel device after tc update skb
    https://git.kernel.org/netdev/net/c/4fbef0f8ea63
  - [net,V2,06/10] net/mlx5e: Fix error flow in representor failing to add vport rx rule
    https://git.kernel.org/netdev/net/c/0a6b069cc60d
  - [net,V2,07/10] Revert "net/mlx5: Remove "recovery" arg from mlx5_load_one() function"
    https://git.kernel.org/netdev/net/c/21608a2cf38e
  - [net,V2,08/10] net/mlx5: Use recovery timeout on sync reset flow
    https://git.kernel.org/netdev/net/c/dfad99750c0f
  - [net,V2,09/10] net/mlx5e: Nullify table pointer when failing to create
    https://git.kernel.org/netdev/net/c/1b540decd03a
  - [net,V2,10/10] Revert "net/mlx5e: Don't use termination table when redundant"
    https://git.kernel.org/netdev/net/c/081abcacaf0a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html