netdev - Re: [PATCHv2 net 2/3] tipc: do not update mtu if msg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 3 May 2023 19:55:09 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jon Maloy <jmaloy@...hat.com>, Xin Long <lucien.xin@...il.com>
Cc: Tung Quang Nguyen <tung.q.nguyen@...tech.com.au>, network dev
 <netdev@...r.kernel.org>, "tipc-discussion@...ts.sourceforge.net"
 <tipc-discussion@...ts.sourceforge.net>, "davem@...emloft.net"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>
Subject: Re: [PATCHv2 net 2/3] tipc: do not update mtu if msg_max is too
 small in mtu negotiation

On Wed, 3 May 2023 15:29:07 -0400 Jon Maloy wrote:
> > I think it's correct to NOT use ''---' for version changes, see the
> > comment from davem:
> >
> >    https://lore.kernel.org/netdev/20160415.172858.253625178036493951.davem@davemloft.net/
> >
> > unless there are some new rules I missed.  
> I have not seen this one before, and I disagree with David here. Many of 
> the changes
> between versions are trivial, and some comments even incomprehensible 
> once the patch has
> been applied.
> I have always put them after the "---" comment, and I will continue to 
> do so until David starts
> rejecting such patches.
> 
> But ok, do as you find right.

Yes, I think the motivation has changed a bit since we now have 
the permanent lore archive and we add links when applying patches.
The change log is easy to find on lore, even after the --- delimiter.