netdev - Re: [PATCH v3 net] bonding: add xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 5 May 2023 09:11:56 +0300
From: Jussi Maki <joamaki@...il.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: netdev@...r.kernel.org, lorenzo.bianconi@...hat.com, j.vosburgh@...il.com, 
	andy@...yhouse.net, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, bpf@...r.kernel.org, andrii@...nel.org, mykolal@...com, 
	ast@...nel.org, daniel@...earbox.net, martin.lau@...ux.dev, alardam@...il.com, 
	memxor@...il.com, sdf@...gle.com, brouer@...hat.com, toke@...hat.com
Subject: Re: [PATCH v3 net] bonding: add xdp_features support

On Thu, May 4, 2023 at 12:52 PM Lorenzo Bianconi <lorenzo@...nel.org> wrote:
>
> Introduce xdp_features support for bonding driver according to the slave
> devices attached to the master one. xdp_features is required whenever we
> want to xdp_redirect traffic into a bond device and then into selected
> slaves attached to it.
>
> Reviewed-by: Simon Horman <simon.horman@...igine.com>
> Acked-by: Jay Vosburgh <jay.vosburgh@...onical.com>
> Fixes: 66c0e13ad236 ("drivers: net: turn on XDP features")
> Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>

Reviewed-by: Jussi Maki <joamaki@...il.com>
Tested-by: Jussi Maki <joamaki@...il.com>

> +void bond_xdp_set_features(struct net_device *bond_dev)
> +{
> +       struct bonding *bond = netdev_priv(bond_dev);

Minor nit: could we instead take "struct bonding *" as an argument here?