netdev - Re: [regression] Kernel OOPS on boot with Kernel 6.3(.1) and RTL8153 Gigabit Ethernet Adapter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sun, 07 May 2023 20:32:16 +0200
From: Bjørn Mork <bjorn@...k.no>
To: Jakub Kicinski <kuba@...nel.org>
Cc: "Linux regression tracking (Thorsten Leemhuis)" <regressions@...mhuis.info>,
        Hayes Wang <hayeswang@...ltek.com>,
        Linux regressions mailing list <regressions@...ts.linux.dev>,
        netdev@...r.kernel.org, Paolo Abeni <pabeni@...hat.com>,
        Eric Dumazet <edumazet@...gle.com>,
        "David S. Miller" <davem@...emloft.net>,
        Stanislav Fomichev <sdf@...ichev.me>
Subject: Re: [regression] Kernel OOPS on boot with Kernel 6.3(.1) and
 RTL8153 Gigabit Ethernet Adapter

Jakub Kicinski <kuba@...nel.org> writes:

> It's just a hashtable init, I think that we can do:
>
> diff --git a/kernel/bpf/offload.c b/kernel/bpf/offload.c
> index d9c9f45e3529..8a26cd8814c1 100644
> --- a/kernel/bpf/offload.c
> +++ b/kernel/bpf/offload.c
> @@ -859,4 +859,4 @@ static int __init bpf_offload_init(void)
>  	return rhashtable_init(&offdevs, &offdevs_params);
>  }
>  
> -late_initcall(bpf_offload_init);
> +core_initcall(bpf_offload_init);
>
>
> Thorsten, how is the communication supposed to work in this case?
> Can you ask the reporter to test this? I don't see them on CC...

FWIW, I tried to reproduce the oops in the hope that I could confirm
a fix.  But I failed. The netdev is successfully deregistered on my
laptop no matter what I do. Tested v6.3 and current net/main, and
tried different tricks to change probe timing.

Guess this is timing sensitive enough that it only shows up on certain
systems.

So we will need the reporter to chime in.


Bjørn