netdev - Re: [PATCH net-next,v2] mac80211_hwsim: fix memory leak in hwsim_new_radio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 15 May 2023 19:07:11 +0800
From: shaozhengchao <shaozhengchao@...wei.com>
To: Kalle Valo <kvalo@...nel.org>
CC: <linux-wireless@...r.kernel.org>, <netdev@...r.kernel.org>,
	<johannes@...solutions.net>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuba@...nel.org>, <pabeni@...hat.com>, <jaewan@...gle.com>,
	<steen.hegelund@...rochip.com>, <weiyongjun1@...wei.com>,
	<yuehaibing@...wei.com>,
	<syzbot+904ce6fbb38532d9795c@...kaller.appspotmail.com>
Subject: Re: [PATCH net-next,v2] mac80211_hwsim: fix memory leak in
 hwsim_new_radio_nl



On 2023/5/15 19:01, Kalle Valo wrote:
> Zhengchao Shao <shaozhengchao@...wei.com> writes:
> 
>> When parse_pmsr_capa failed in hwsim_new_radio_nl, the memory resources
>> applied for by pmsr_capa are not released. Add release processing to the
>> incorrect path.
>>
>> Fixes: 92d13386ec55 ("mac80211_hwsim: add PMSR capability support")
>> Reported-by: syzbot+904ce6fbb38532d9795c@...kaller.appspotmail.com
>> Signed-off-by: Zhengchao Shao <shaozhengchao@...wei.com>
>> ---
>> v2: move the value assigned to pmsr_capa before parse_pmsr_capa
>> ---
>>   drivers/net/wireless/virtual/mac80211_hwsim.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> drivers/net/wireless changes go to wireless-next, not net-next. But no
> need to resend because of this.
> 

Thank you for the reminder. I will pay attention next time.

Zhengchao Shao