[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Tue, 6 Jun 2023 10:13:44 +0800
From: Hangyu Hua <hbh25y@...il.com>
To: Simon Horman <simon.horman@...igine.com>
Cc: jhs@...atatu.com, xiyou.wangcong@...il.com, jiri@...nulli.us,
davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
pabeni@...hat.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net] net: sched: fix possible refcount leak in
tc_chain_tmplt_add()
On 5/6/2023 20:31, Simon Horman wrote:
> On Mon, Jun 05, 2023 at 03:01:58PM +0800, Hangyu Hua wrote:
>> try_module_get can be called in tcf_proto_lookup_ops. So if ops don't
>> implement the corresponding function we should call module_put to drop
>> the refcount.
>
> Hi Hangyu Hua,
>
> Is this correct even if try_module_get() is
> not called via tcf_proto_lookup_ops() ?
>
tcf_proto_lookup_ops will return error if try_module_get() is not called
in tcf_proto_lookup_ops(). I am not sure what you mean?
Thanks,
Hangyu
>> Fixes: 9f407f1768d3 ("net: sched: introduce chain templates")
>> Signed-off-by: Hangyu Hua <hbh25y@...il.com>
>> ---
>> net/sched/cls_api.c | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/net/sched/cls_api.c b/net/sched/cls_api.c
>> index 2621550bfddc..92bfb892e638 100644
>> --- a/net/sched/cls_api.c
>> +++ b/net/sched/cls_api.c
>> @@ -2952,6 +2952,7 @@ static int tc_chain_tmplt_add(struct tcf_chain *chain, struct net *net,
>> return PTR_ERR(ops);
>> if (!ops->tmplt_create || !ops->tmplt_destroy || !ops->tmplt_dump) {
>> NL_SET_ERR_MSG(extack, "Chain templates are not supported with specified classifier");
>> + module_put(ops->owner);
>> return -EOPNOTSUPP;
>> }
>>
>> --
>> 2.34.1
>>
>>
Powered by blists - more mailing lists