netdev - Re: [PATCH v3] MAINTAINERS: Add new maintainers to Redpine driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Sat, 10 Jun 2023 14:32:41 +0200
From: Marek Vasut <marex@...x.de>
To: Angus Ainslie <angus@...ea.ca>,
 Jérôme Pouiller <jerome.pouiller@...abs.com>
Cc: Kalle Valo <kvalo@...nel.org>,
 Ganapathi Kondraju <ganapathi.kondraju@...abs.com>,
 linux-wireless@...r.kernel.org, Amitkumar Karwar <amitkarwar@...il.com>,
 Amol Hanwate <amol.hanwate@...abs.com>, Jakub Kicinski <kuba@...nel.org>,
 Johannes Berg <johannes@...solutions.net>,
 Martin Fuzzey <martin.fuzzey@...wbird.group>,
 Martin Kepplinger <martink@...teo.de>,
 Narasimha Anumolu <narasimha.anumolu@...abs.com>,
 Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>,
 Shivanadam Gude <shivanadam.gude@...abs.com>,
 Siva Rebbagondla <siva8118@...il.com>,
 Srinivas Chappidi <srinivas.chappidi@...abs.com>, netdev@...r.kernel.org
Subject: Re: [PATCH v3] MAINTAINERS: Add new maintainers to Redpine driver

On 6/9/23 17:46, Angus Ainslie wrote:
> Hi Jérôme,
> 
> On 2023-06-09 08:10, Jérôme Pouiller wrote:
>>
>> You are talking about this driver[1] I assume?
>>
>> [1]: https://github.com/SiliconLabs/RS911X-nLink-OSD
>>
>> [...]
>>> In the meantime, since RSI neglected this driver for years, what would
>>> be the suggestion for people who are stuck with the RSI WiFi hardware?
>>
>> Unfortunately, my only suggestion is to use the downstream driver we
>> mentioned above.
> 
> That driver isn't really a solution as it rarely applies cleanly to 
> recent kernels.
> 
> The lack of proper commit messages also makes the changes opaque.

Worse, that repo is just massive dump of unreviewed, unreviewable, 
obfuscated goo. That is something I would never dare to put into any 
serious deployment.

To make it clear, the aforementioned suggestion is NOT an option.