netdev - Re: [PATCH net-next v2] net: ngbe: add Wake on Lan support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Sun, 25 Jun 2023 15:39:18 +0800
From: "mengyuanlou@...-swift.com" <mengyuanlou@...-swift.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org
Subject: Re: [PATCH net-next v2] net: ngbe: add Wake on Lan support



> 2023年6月23日 10:25，Jakub Kicinski <kuba@...nel.org> 写道：
> 
> On Wed, 21 Jun 2023 17:47:44 +0800 Mengyuan Lou wrote:
>> + if (wol->wolopts & WAKE_MAGIC)
>> + return -EOPNOTSUPP;
>> +
>> + wx->wol = 0;
>> + if (wol->wolopts & WAKE_MAGIC)
> 
> Maybe my eyes deceive me but it looks like you're rejecting all
> configurations with WAKE_MAGIC set and then only supporting WAKE_MAGIC.
> Did you mean to negate the first check?
> 
> How did you test this change?
Sorry, I just test that "ethtool -s eth0 wol d” to close Wol.
And I forgot to test “ethtool -s eth0 wol g” to reopen it. 

> -- 
> pw-bot: cr
> 
>