netdev - RE: net: tipc: Remove repeated “initialization” in tipc_group_add_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 7 Jul 2023 10:25:44 +0000
From: Tung Quang Nguyen <tung.q.nguyen@...tech.com.au>
To: 王明-软件底层技术部 <machel@...o.com>,
	"tipc-discussion@...ts.sourceforge.net"
	<tipc-discussion@...ts.sourceforge.net>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>
CC: Dan Carpenter <dan.carpenter@...aro.org>, "David S. Miller"
	<davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
	<kuba@...nel.org>, Jon Maloy <jmaloy@...hat.com>, Paolo Abeni
	<pabeni@...hat.com>, Ying Xue <ying.xue@...driver.com>, Markus Elfring
	<Markus.Elfring@....de>, Christophe Jaillet <christophe.jaillet@...adoo.fr>,
	"opensource.kernel@...o.com" <opensource.kernel@...o.com>
Subject:
 RE: net: tipc: Remove repeated “initialization” in tipc_group_add_to_tree()

> -               parent = *n;
> -               tmp = container_of(parent, struct tipc_member, tree_node);
>                 nkey = (u64)tmp->node << 32 | tmp->port;
>                 if (key < nkey)
>                         n = &(*n)->rb_left;
[RESEND]
Your patch breaks my test suite. You introduced a new bug which was pointed out by Christophe.
It is a redundant assignment to variable tmp as you pointed out.
I suggest that you repost this cleanup together with other patches that you see need to be refactored (I believe there are still many things like this in TIPC) in the future, or I can do what you suggested in my future cleanup.